-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema export via reactive driver and fix for bug #113 #118
Conversation
Alright, folks, so shall I merge this one? |
add method to fetch snapshot using reactive client
make work done in ForeignKeys reactive note that I'm really not happy with this code at all
avoid creating so many long chains of CompletionStages
Silence indicates consent. |
No, it doesn't |
Maybe if you put a deadline. Anyway, it looks good, feel free to merge it |
Pushed manually. |
This has broken CI because it depends on core 5.5.0-SNAPSHOT. I'll create a new PR that does a clone+build of core 5.5.0-SNAPSHOT so we can still have CI coverage until the next version of core is released. Aside from that, it looks like the user has to do 2 things to enable this:
Can we make it so these steps happen automatically and the user gets the RX-based schema creation out of the box? |
The new ORM release will be ready shortly, before the end of the day. We decided to do an exception for this time and merge the PRs even if they refer to an unreleased version. |
Yes, I was already working on that, and I just pushed the result. |
Excuse me: I have pushed part 1 but not yet part 2. |
@gavinking Any idea about this error? https://github.com/hibernate/hibernate-reactive/pull/122/checks#step:4:151 |
I imagine you're referring to the test failure I fixed here. |
Yes, it's working now, thanks
…On Mon, May 18, 2020 at 6:56 PM Gavin King ***@***.***> wrote:
@gavinking <https://github.com/gavinking> Any idea about this error?
https://github.com/hibernate/hibernate-reactive/pull/122/checks#step:4:151
I imagine you're referring to the test failure I fixed here
<4e8b51a>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEIQ5K7RBPSAW4HVJKWHT3RSFZFVANCNFSM4NC7JVYQ>
.
|
This supersedes #112.