Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test TimeZoneStorage #1722

Merged
merged 1 commit into from Aug 9, 2023
Merged

Test TimeZoneStorage #1722

merged 1 commit into from Aug 9, 2023

Conversation

blafond
Copy link
Member

@blafond blafond commented Jul 26, 2023 •
edited by DavideD

fixes #1442

@blafond blafond force-pushed the 1442-timezone-storage-test branch from 8a8afe0 to 839e451 Compare July 27, 2023 20:25
@blafond
Copy link
Member Author

blafond commented Jul 28, 2023

The design looks clean but Just discovered that that @EnabledIf("doIfTrue") annotation get's run via reflection before our our hibernate config is set-up, so sessionFactory hasn't started and dialect is null, so getDialect() fails.... so only the non-annotated tests will actually run.

Going to take more work.

@blafond blafond force-pushed the 1442-timezone-storage-test branch from 839e451 to fc7b1ba Compare July 31, 2023 19:29
@blafond blafond changed the title [#1442] Test TimeZoneStorage annotation [#1442] Test TimeZoneStorage Jul 31, 2023
@blafond
[hibernate#1442] Add test for TimeZoneStorage
581f95b 
   - Disabled for SQLServer which does not support java.time.OffsetTime
@blafond
Copy link
Member Author

blafond commented Aug 8, 2023

@DavideD Pushed a change that works for all DB's except SQLSERVER. Fixed my local DB2 & ORACLE failures by adding the missing `@Timeout(value = 10, timeUnit = MINUTES)' annotation

I'm good with this version.

@DavideD
Copy link
Member

DavideD commented Aug 8, 2023

Thanks, I will have a look

@DavideD DavideD merged commit 49bb128 into hibernate:main Aug 9, 2023
20 checks passed
@DavideD DavideD changed the title [#1442] Test TimeZoneStorage Test TimeZoneStorage Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavideD DavideD DavideD left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test TimeZoneStorage annotation
2 participants
@blafond @DavideD