Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setOrder #1815

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Support setOrder #1815

merged 2 commits into from
Dec 14, 2023

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Dec 13, 2023

fix #1735
Supersedes #1813

@DavideD DavideD requested a review from blafond December 13, 2023 16:16
@DavideD DavideD mentioned this pull request Dec 13, 2023
Closed
blafond
blafond approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@blafond blafond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change... the test has an unused import:

import static org.junit.jupiter.api.Assertions.assertEquals;

@DavideD
Copy link
Member Author

DavideD commented Dec 13, 2023

Thanks, there also something else that doesn't work. I'm looking into it

@blafond
Copy link
Member

blafond commented Dec 13, 2023

I tested locally and there are some failed tests :(

@DavideD
Copy link
Member Author

DavideD commented Dec 13, 2023

Should be fixed now, let's see what CI think about it

@DavideD DavideD merged commit 939e567 into hibernate:main Dec 14, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blafond blafond blafond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Order
2 participants
@DavideD @blafond