Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable or enable test for database types using annotations #1842

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Disable or enable test for database types using annotations #1842

merged 4 commits into from
Jan 23, 2024

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Jan 22, 2024

Fix #1827
Supersedes #1828

@DavideD DavideD requested a review from blafond January 22, 2024 12:32
@DavideD DavideD changed the title Disable or enabe test using annoations Disable or enable test for database types using annotations Jan 22, 2024
blafond
blafond approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@blafond blafond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the annotation changes.. yes, it's simpler and cleans up their tests.

I walked through the real test changes and checked that the comment messages were converted to the annotation "reason =".

@DavideD DavideD merged commit 4d8c5a6 into hibernate:main Jan 23, 2024
21 checks passed
@DavideD
Copy link
Member Author

DavideD commented Jan 23, 2024

Thanks,
merged!

@DavideD DavideD deleted the issue_1827-v2 branch January 23, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blafond blafond blafond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace DBSelectionExtension with annotations
2 participants
@DavideD @blafond