Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Hibernate ORM to 6.5.0.CR2 #1880

Merged
merged 8 commits into from
Apr 15, 2024
Merged

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Apr 15, 2024

Fix #1857
Fix #1878
Fix #1872
Fix #1879

Comment on lines +194 to +202
mutationGroup.forEachOperation( (position, jdbcOperation) -> {
if ( id == null ) {
assert entityPersister().getIdentityInsertDelegate() != null;
}
else {
final EntityTableMapping tableDetails = (EntityTableMapping) jdbcOperation.getTableDetails();
breakDownJdbcValue( id, session, jdbcValueBindings, tableDetails );
}
} );

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
MutationOperationGroup.forEachOperation
should be avoided because it has been deprecated.

default CompletionStage<GeneratedValues> performReactiveNonBatchedOperations(
Object modelReference,
ValuesAnalysis valuesAnalysis,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'valuesAnalysis' is never used.
@@ -141,7 +141,8 @@
}
final JdbcValueBindings jdbcValueBindings = mutationExecutor.getJdbcValueBindings();
bindPartitionColumnValueBindings( loadedState, session, jdbcValueBindings );
applyId( id, rowId, mutationExecutor, getStaticDeleteGroup(), session );
applyId( id, rowId, mutationExecutor, getStaticMutationOperationGroup(), session );
String[] identifierColumnNames = entityPersister().getIdentifierColumnNames();

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'String[] identifierColumnNames' is never read.
@DavideD DavideD merged commit 2c902f8 into hibernate:main Apr 15, 2024
21 checks passed
@DavideD DavideD deleted the 1857-orm-upgrade branch April 19, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant