Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference documentation style sheet #1883

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Apr 16, 2024

Fix #1882:

  • Replace prettify with rouge (solve the CSP issue with prettify.css)
  • Add Hibernate logo on top of the documentation page
  • Apply some changes to the default CS

I've updated staging.hibernate.org with the new CSS. It seems close enough to the one used by prettify.

/cc @marko-bekhta

@DavideD DavideD requested a review from gavinking April 16, 2024 15:27
@marko-bekhta
Copy link
Member

image
hmm 🙈 maybe you need to explicitly specify the highlighter in the gradle task ?

* Replace `prettify` with `rouge` (solve the CSP error with prettify.css)
* Add Hibernate logo on top of the documentation page
* Apply some changes to the default CS
@DavideD
Copy link
Member Author

DavideD commented Apr 16, 2024

hmm 🙈 maybe you need to explicitly specify the highlighter in the gradle task ?

Yes, specifying the highlighter is helpful 😺
Sorry, I did a last minute change and forgot to update the file.
Should be fixed now.

@gavinking
Copy link
Member

LGTM, thanks @DavideD

@DavideD DavideD merged commit a8e757f into hibernate:main Apr 17, 2024
21 checks passed
@DavideD
Copy link
Member Author

DavideD commented Apr 17, 2024

Merged, thanks.
The documentation in production will be updated after the next release.

@DavideD DavideD deleted the 1882-update-docs branch April 19, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up Hibernate Reactive documentation page
3 participants