Drop extra Databases and update README #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for multitenancy needs to be able to create additional databaseses but it needs the right permissions if the user starts Postgres without Docker/Podman.
This way we can use them with `@AfterClass` and `@BeforeClass` if we need it for a test
A small optimization
Closed
|
I don't think one needs additional permission to drop the database if they've created it. |
|
Great, thanks :-)
Nope, it seems not. |
|
Oops, what did I do?! It didn't pass the CI build, and I didn't notice. I did test it locally. |
|
Ugh, it broke the tests on Cockroach. I should definitely not have merged it. Sorry. |
|
Yeah, I noticed. No problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of missing bits for #754