HSEARCH-2219 Use a proper cast in unwrap() method in AnalyzerReferenc…

…e implementations This prevents ClassCastException to happen in places where there does not seem to be a cast.
hibernate · Dec 19, 2016 · 13656d1 · 13656d1
1 parent e5545cd
commit 13656d1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/engine/src/main/java/org/hibernate/search/analyzer/impl/LuceneAnalyzerReference.java b/engine/src/main/java/org/hibernate/search/analyzer/impl/LuceneAnalyzerReference.java
@@ -37,9 +37,8 @@ public <T extends AnalyzerReference> boolean is(Class<T> analyzerType) {
 	}
 
 	@Override
-	@SuppressWarnings("unchecked")
 	public <T extends AnalyzerReference> T unwrap(Class<T> analyzerType) {
-		return (T) this;
+		return analyzerType.cast( this );
 	}
 
 	@Override

diff --git a/engine/src/main/java/org/hibernate/search/analyzer/impl/RemoteAnalyzerReference.java b/engine/src/main/java/org/hibernate/search/analyzer/impl/RemoteAnalyzerReference.java
@@ -39,9 +39,8 @@ public <T extends AnalyzerReference> boolean is(Class<T> analyzerType) {
 	}
 
 	@Override
-	@SuppressWarnings("unchecked")
 	public <T extends AnalyzerReference> T unwrap(Class<T> analyzerType) {
-		return (T) this;
+		return analyzerType.cast( this );
 	}
 
 	@Override

diff --git a/engine/src/main/java/org/hibernate/search/util/impl/ScopedAnalyzerReference.java b/engine/src/main/java/org/hibernate/search/util/impl/ScopedAnalyzerReference.java
@@ -48,21 +48,20 @@ else if ( RemoteAnalyzerReference.class.isAssignableFrom( analyzerType ) ) {
 	}
 
 	@Override
-	@SuppressWarnings("unchecked")
 	public <T extends AnalyzerReference> T unwrap(Class<T> analyzerType) {
 		if ( LuceneAnalyzerReference.class.isAssignableFrom( analyzerType ) ) {
 			if ( !( scopedAnalyzer instanceof ScopedLuceneAnalyzer ) ) {
 				throw log.scopedAnalyzerIsNotLucene( scopedAnalyzer );
 			}
-			return (T) new LuceneAnalyzerReference( (ScopedLuceneAnalyzer) scopedAnalyzer );
+			return analyzerType.cast( new LuceneAnalyzerReference( (ScopedLuceneAnalyzer) scopedAnalyzer ) );
 		}
 		else if ( RemoteAnalyzerReference.class.isAssignableFrom( analyzerType ) ) {
 			if ( !( scopedAnalyzer instanceof ScopedRemoteAnalyzer ) ) {
 				throw log.scopedAnalyzerIsNotRemote( scopedAnalyzer );
 			}
-			return (T) new RemoteAnalyzerReference( (ScopedRemoteAnalyzer) scopedAnalyzer );
+			return analyzerType.cast( new RemoteAnalyzerReference( (ScopedRemoteAnalyzer) scopedAnalyzer ) );
 		}
-		return (T) this;
+		return analyzerType.cast( this );
 	}
 
 	@Override