Skip to content

Commit

Permalink
HSEARCH-5094 Merge goals ci-build with ci-sources-check
Browse files Browse the repository at this point in the history
Because we don't need automatic formatting on CI,
so we always want to be in "check" mode,
and doing so allows for better caching.
  • Loading branch information
yrodiere committed Mar 1, 2024
1 parent 7dfe05b commit 24f1637
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:
- name: Building code and running unit tests and basic checks
run: |
./mvnw $MAVEN_ARGS ${{ matrix.os.maven.args }} clean install \
-Pjqassistant -Pdist -Pci-sources-check -DskipITs
-Pjqassistant -Pdist -Pci-build -DskipITs
env:
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
- name: Running integration tests in the default environment
Expand Down
2 changes: 1 addition & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ stage('Default build') {
mvn \
${commonMavenArgs} \
-Pdist \
-Pjqassistant -Pci-sources-check \
-Pjqassistant -Pci-build \
-DskipITs \
clean \
${deploySnapshot ? "\
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1591,7 +1591,7 @@
</profile>

<profile>
<id>ci-sources-check</id>
<id>ci-build</id>
<properties>
<goal.impsort-maven-plugin>check</goal.impsort-maven-plugin>
<goal.formatter-maven-plugin>validate</goal.formatter-maven-plugin>
Expand Down

0 comments on commit 24f1637

Please sign in to comment.