HSEARCH-4926 Improve casts in HashTable

This doesn't change the behavior in practice, but is slightly more
correct, and will avoid Sonar reporting a bug.

util/common/src/main/java/org/hibernate/search/util/common/data/impl/HashTable.java

@@ -16,11 +16,10 @@
  */
 public abstract class HashTable<T> implements Iterable<T> {
 
-	final T[] buckets;
+	final Object[] buckets;
 
-	@SuppressWarnings("unchecked")
 	HashTable(int size) {
-		this.buckets = (T[]) new Object[size];
+		this.buckets = new Object[size];
 	}
 
 	/**
@@ -41,11 +40,12 @@ public boolean hasNext() {
 			}
 
 			@Override
+			@SuppressWarnings("unchecked")
 			public T next() {
 				if ( !hasNext() ) {
 					throw new NoSuchElementException();
 				}
-				return buckets[index++];
+				return (T) buckets[index++];
 			}
 		};
 	}
@@ -63,8 +63,9 @@ public final T get(CharSequence key) {
 	 * @return The content of the bucket at index {@code index}.
 	 * @throws ArrayIndexOutOfBoundsException If the given index is negative or higher than the table's size.
 	 */
+	@SuppressWarnings("unchecked")
 	public final T get(int index) {
-		return buckets[index];
+		return (T) buckets[index];
 	}
 
 	/**