Skip to content

Commit

Permalink
HSEARCH-3478 Sonar: Class names should not shadow interfaces or super…
Browse files Browse the repository at this point in the history
…classes
  • Loading branch information
yrodiere committed Feb 8, 2019
1 parent 09cd099 commit 378de42
Show file tree
Hide file tree
Showing 23 changed files with 28 additions and 28 deletions.
Expand Up @@ -31,7 +31,7 @@ public abstract class AbstractSimpleBulkableElasticsearchWork<R>

private final JsonObject bulkableActionMetadata;

protected AbstractSimpleBulkableElasticsearchWork(Builder<?> builder) {
protected AbstractSimpleBulkableElasticsearchWork(AbstractBuilder builder) {
super( builder );
this.bulkableActionMetadata = builder.buildBulkableActionMetadata();
}
Expand Down Expand Up @@ -103,10 +103,10 @@ private CompletableFuture<R> handleResult(ElasticsearchWorkExecutionContext exec
.thenApply( ignored -> result );
}

protected abstract static class Builder<B>
extends AbstractSimpleElasticsearchWork.Builder<B> {
protected abstract static class AbstractBuilder<B>
extends AbstractSimpleElasticsearchWork.AbstractBuilder<B> {

public Builder(URLEncodedString dirtiedIndexName, ElasticsearchRequestSuccessAssessor resultAssessor) {
public AbstractBuilder(URLEncodedString dirtiedIndexName, ElasticsearchRequestSuccessAssessor resultAssessor) {
super( dirtiedIndexName, resultAssessor );
}

Expand Down
Expand Up @@ -32,7 +32,7 @@ public abstract class AbstractSimpleElasticsearchWork<R> implements Elasticsearc
protected final ElasticsearchRequestSuccessAssessor resultAssessor;
protected final boolean markIndexDirty;

protected AbstractSimpleElasticsearchWork(Builder<?> builder) {
protected AbstractSimpleElasticsearchWork(AbstractBuilder<?> builder) {
this.request = builder.buildRequest();
this.dirtiedIndexName = builder.dirtiedIndexName;
this.resultAssessor = builder.resultAssessor;
Expand Down Expand Up @@ -107,13 +107,13 @@ private CompletableFuture<R> handleResult(ElasticsearchWorkExecutionContext exec
}

@SuppressWarnings("unchecked") // By contract, subclasses must implement B
protected abstract static class Builder<B> {
protected abstract static class AbstractBuilder<B> {
protected final URLEncodedString dirtiedIndexName;
protected ElasticsearchRequestSuccessAssessor resultAssessor;

protected boolean markIndexDirty;

public Builder(URLEncodedString dirtiedIndexName, ElasticsearchRequestSuccessAssessor resultAssessor) {
public AbstractBuilder(URLEncodedString dirtiedIndexName, ElasticsearchRequestSuccessAssessor resultAssessor) {
this.dirtiedIndexName = dirtiedIndexName;
this.resultAssessor = resultAssessor;
}
Expand Down
Expand Up @@ -28,7 +28,7 @@ protected Void generateResult(ElasticsearchWorkExecutionContext context, Elastic
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements ClearScrollWorkBuilder {
private final String scrollId;

Expand Down
Expand Up @@ -24,7 +24,7 @@ protected Void generateResult(ElasticsearchWorkExecutionContext context, Elastic
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements CloseIndexWorkBuilder {

private final URLEncodedString indexName;
Expand Down
Expand Up @@ -35,7 +35,7 @@ protected Long generateResult(ElasticsearchWorkExecutionContext context, Elastic
return COUNT_ACCESSOR.get( body ).get();
}

public static class Builder extends AbstractSimpleElasticsearchWork.Builder<Builder> implements CountWorkBuilder {
public static class Builder extends AbstractBuilder<Builder> implements CountWorkBuilder {

private final List<URLEncodedString> indexNames = new ArrayList<>();
private final List<URLEncodedString> typeNames = new ArrayList<>();
Expand Down
Expand Up @@ -41,7 +41,7 @@ protected CreateIndexResult generateResult(ElasticsearchWorkExecutionContext con
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements CreateIndexWorkBuilder {
private final GsonProvider gsonProvider;
private final URLEncodedString indexName;
Expand Down
Expand Up @@ -48,7 +48,7 @@ protected Void generateResult(ElasticsearchWorkExecutionContext context, Elastic
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements DeleteByQueryWorkBuilder {
private final URLEncodedString indexName;
private final JsonObject payload;
Expand Down
Expand Up @@ -36,7 +36,7 @@ protected Void generateResult(ElasticsearchWorkExecutionContext context, JsonObj
}

public static class Builder
extends AbstractSimpleBulkableElasticsearchWork.Builder<Builder>
extends AbstractSimpleBulkableElasticsearchWork.AbstractBuilder<Builder>
implements DeleteWorkBuilder {
private final URLEncodedString indexName;
private final URLEncodedString typeName;
Expand Down
Expand Up @@ -26,7 +26,7 @@ protected Void generateResult(ElasticsearchWorkExecutionContext context, Elastic
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements DropIndexWorkBuilder {
private final URLEncodedString indexName;

Expand Down
Expand Up @@ -32,7 +32,7 @@ protected ExplainResult generateResult(ElasticsearchWorkExecutionContext context
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements ExplainWorkBuilder {
private final URLEncodedString indexName;
private final URLEncodedString typeName;
Expand Down
Expand Up @@ -46,7 +46,7 @@ protected Void generateResult(ElasticsearchWorkExecutionContext context, Elastic
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements FlushWorkBuilder {
private final RefreshWorkBuilder refreshWorkBuilder;
private final Set<URLEncodedString> indexNames = new HashSet<>();
Expand Down
Expand Up @@ -53,7 +53,7 @@ protected IndexSettings generateResult(ElasticsearchWorkExecutionContext context
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements GetIndexSettingsWorkBuilder {
private final URLEncodedString indexName;

Expand Down
Expand Up @@ -59,7 +59,7 @@ protected RootTypeMapping generateResult(ElasticsearchWorkExecutionContext conte
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements GetIndexTypeMappingWorkBuilder {
private final URLEncodedString indexName;
private final URLEncodedString typeName;
Expand Down
Expand Up @@ -31,7 +31,7 @@ protected Boolean generateResult(ElasticsearchWorkExecutionContext context,
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements IndexExistsWorkBuilder {
private final URLEncodedString indexName;

Expand Down
Expand Up @@ -33,7 +33,7 @@ protected Void generateResult(ElasticsearchWorkExecutionContext context, JsonObj
}

public static class Builder
extends AbstractSimpleBulkableElasticsearchWork.Builder<Builder>
extends AbstractSimpleBulkableElasticsearchWork.AbstractBuilder<Builder>
implements IndexWorkBuilder {
private final URLEncodedString indexName;
private final URLEncodedString typeName;
Expand Down
Expand Up @@ -27,7 +27,7 @@ protected Void generateResult(ElasticsearchWorkExecutionContext context, Elastic
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements OpenIndexWorkBuilder {
private final URLEncodedString indexName;

Expand Down
Expand Up @@ -34,7 +34,7 @@ protected Void generateResult(ElasticsearchWorkExecutionContext context, Elastic
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements OptimizeWorkBuilder {
private List<URLEncodedString> indexNames = new ArrayList<>();

Expand Down
Expand Up @@ -32,7 +32,7 @@ protected Void generateResult(ElasticsearchWorkExecutionContext context, Elastic
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements PutIndexSettingsWorkBuilder {
private final URLEncodedString indexName;
private final JsonObject payload;
Expand Down
Expand Up @@ -32,7 +32,7 @@ protected Void generateResult(ElasticsearchWorkExecutionContext context, Elastic
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements PutIndexMappingWorkBuilder {
private final URLEncodedString indexName;
private final URLEncodedString typeName;
Expand Down
Expand Up @@ -30,7 +30,7 @@ protected Void generateResult(ElasticsearchWorkExecutionContext context, Elastic
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements RefreshWorkBuilder {
private List<URLEncodedString> indexNames = new ArrayList<>();

Expand Down
Expand Up @@ -33,7 +33,7 @@ protected ElasticsearchLoadableSearchResult<T> generateResult(ElasticsearchWorkE
}

public static class Builder<T>
extends AbstractSimpleElasticsearchWork.Builder<Builder<T>>
extends AbstractBuilder<Builder<T>>
implements ScrollWorkBuilder<T> {
private final String scrollId;
private final String scrollTimeout;
Expand Down
Expand Up @@ -54,7 +54,7 @@ protected ElasticsearchLoadableSearchResult<T> generateResult(ElasticsearchWorkE
}

public static class Builder<T>
extends AbstractSimpleElasticsearchWork.Builder<Builder<T>>
extends AbstractBuilder<Builder<T>>
implements SearchWorkBuilder<T> {
private final JsonObject payload;
private final ElasticsearchSearchResultExtractor<T> resultExtractor;
Expand Down
Expand Up @@ -36,7 +36,7 @@ protected Void generateResult(ElasticsearchWorkExecutionContext context, Elastic
}

public static class Builder
extends AbstractSimpleElasticsearchWork.Builder<Builder>
extends AbstractBuilder<Builder>
implements WaitForIndexStatusWorkBuilder {
private final URLEncodedString indexName;
private final ElasticsearchIndexStatus requiredStatus;
Expand Down

0 comments on commit 378de42

Please sign in to comment.