Skip to content

Commit

Permalink
HSEARCH-3277 Avoid raw ScrollableResults
Browse files Browse the repository at this point in the history 
We can't use an actual type for now, just a wildcard, because ORM
returns a raw type.

Signed-off-by: Yoann Rodière <yoann@hibernate.org>
  • Loading branch information
@yrodiere @marko-bekhta
yrodiere authored and marko-bekhta committed Sep 25, 2023
1 parent 12e7582 commit 694da2e
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 22 deletions.
38 changes: 19 additions & 19 deletions ...search/integrationtest/mapper/orm/hibernateormapis/ToHibernateOrmScrollableResultsIT.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public void initData() {
public void next() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

assertThat( scroll.getRowNumber() ).isEqualTo( -1 );
Expand Down Expand Up @@ -130,7 +130,7 @@ public void next() {
public void previous() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

assertThat( scroll.getRowNumber() ).isEqualTo( -1 );
Expand Down Expand Up @@ -185,7 +185,7 @@ public void previous() {
public void scrollMode_forwardsOnly() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll( ScrollMode.FORWARD_ONLY ) ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll( ScrollMode.FORWARD_ONLY ) ) {
backendMock.verifyExpectationsMet();
for ( int i = 0; i < ENTITY_COUNT; i++ ) {
expectScrollNextIfNecessary( i, DEFAULT_FETCH_SIZE, ENTITY_COUNT );
Expand Down Expand Up @@ -224,7 +224,7 @@ public void fetchSize() {
int customFetchSize = 10;
backendMock.expectScrollObjects( Collections.singletonList( IndexedEntity.NAME ),
customFetchSize, b -> {} );
try ( ScrollableResults scroll = Search.toOrmQuery( Search.session( session )
try ( ScrollableResults<?> scroll = Search.toOrmQuery( Search.session( session )
.search( IndexedEntity.class )
.where( f -> f.matchAll() )
.loading( o -> o.fetchSize( customFetchSize ) )
Expand Down Expand Up @@ -270,7 +270,7 @@ public void maxResults() {
.toQuery() );
query.setMaxResults( maxResults );
expectScrollCreate();
try ( ScrollableResults scroll = query.scroll() ) {
try ( ScrollableResults<?> scroll = query.scroll() ) {
backendMock.verifyExpectationsMet();

assertThat( scroll.getRowNumber() ).isEqualTo( -1 );
Expand Down Expand Up @@ -305,7 +305,7 @@ public void maxResults() {
public void scroll() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

assertThat( scroll.getRowNumber() ).isEqualTo( -1 );
Expand Down Expand Up @@ -414,7 +414,7 @@ public void scroll() {
public void scroll_backwards() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

assertThat( scroll.getRowNumber() ).isEqualTo( -1 );
Expand Down Expand Up @@ -469,7 +469,7 @@ public void scroll_backwards() {
public void setRowNumber() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

assertThat( scroll.getRowNumber() ).isEqualTo( -1 );
Expand Down Expand Up @@ -553,7 +553,7 @@ public void setRowNumber() {
public void setRowNumber_backwards() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

assertThat( scroll.getRowNumber() ).isEqualTo( -1 );
Expand Down Expand Up @@ -595,7 +595,7 @@ public void setRowNumber_backwards() {
public void setRowNumber_relativeToEnd() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

assertThat( scroll.getRowNumber() ).isEqualTo( -1 );
Expand Down Expand Up @@ -805,7 +805,7 @@ public void position_relativeToEnd() {
public void beforeFirst_fromBeforeFirst() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

assertThat( scroll.getRowNumber() ).isEqualTo( -1 );
Expand Down Expand Up @@ -842,7 +842,7 @@ public void beforeFirst_fromBeforeFirst() {
public void beforeFirst_fromFirstOrAfter() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

assertThat( scroll.getRowNumber() ).isEqualTo( -1 );
Expand Down Expand Up @@ -878,7 +878,7 @@ public void beforeFirst_fromFirstOrAfter() {
public void first() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

assertThat( scroll.getRowNumber() ).isEqualTo( -1 );
Expand Down Expand Up @@ -932,7 +932,7 @@ public void first() {
public void first_fromAfterFirst() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

backendMock.expectNextScroll( Collections.singletonList( IndexedEntity.NAME ),
Expand Down Expand Up @@ -963,7 +963,7 @@ public void first_fromAfterFirst() {
public void last() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

backendMock.expectNextScroll( Collections.singletonList( IndexedEntity.NAME ),
Expand Down Expand Up @@ -1040,7 +1040,7 @@ public void last() {
public void afterLast_fromLastOrBefore() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

backendMock.expectNextScroll( Collections.singletonList( IndexedEntity.NAME ),
Expand Down Expand Up @@ -1070,7 +1070,7 @@ public void afterLast_fromLastOrBefore() {
public void afterLast_fromAfterLast() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

backendMock.expectNextScroll( Collections.singletonList( IndexedEntity.NAME ),
Expand Down Expand Up @@ -1130,7 +1130,7 @@ public void afterLast_fromAfterLast() {
public void close() {
setupHolder.runInTransaction( session -> {
expectScrollCreate();
try ( ScrollableResults scroll = createSimpleQuery( session ).scroll() ) {
try ( ScrollableResults<?> scroll = createSimpleQuery( session ).scroll() ) {
backendMock.verifyExpectationsMet();

ScrollableResultsImplementor implementor = (ScrollableResultsImplementor) scroll;
Expand Down Expand Up @@ -1172,7 +1172,7 @@ public void timeout() {
setupHolder.runInTransaction( session -> {
backendMock.expectScrollObjects( Collections.singletonList( IndexedEntity.NAME ),
DEFAULT_FETCH_SIZE, b -> b.failAfter( 200, TimeUnit.MILLISECONDS ) );
try ( ScrollableResults scroll = createSimpleQuery( session )
try ( ScrollableResults<?> scroll = createSimpleQuery( session )
.setHint( "jakarta.persistence.query.timeout", 200 )
.scroll() ) {
backendMock.verifyExpectationsMet();
Expand Down
2 changes: 1 addition & 1 deletion ...rnate/search/batch/jsr352/core/massindexing/step/impl/HibernateSearchPartitionMapper.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ private List<PartitionBound> buildPartitionUnitsFrom(EntityManagerFactory emf, S
query.setMaxResults( maxResults );
}

try ( ScrollableResults scroll = query.scroll( ScrollMode.SCROLL_SENSITIVE ) ) {
try ( ScrollableResults<?> scroll = query.scroll( ScrollMode.SCROLL_SENSITIVE ) ) {
/*
* The scroll results are originally positioned *before* the first element,
* so we need to scroll rowsPerPartition + 1 positions to advanced to the
Expand Down
4 changes: 2 additions & 2 deletions .../main/java/org/hibernate/search/batch/jsr352/core/massindexing/step/spi/EntityReader.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ else if ( lowerBound != null ) {

private interface FetchingStrategy {

ScrollableResults createScroll(Session session, CheckpointInfo lastCheckpointInfo);
ScrollableResults<?> createScroll(Session session, CheckpointInfo lastCheckpointInfo);

}

Expand All @@ -413,7 +413,7 @@ private static class ChunkState implements AutoCloseable {
private final int clearInterval;

private Session session;
private ScrollableResults scroll;
private ScrollableResults<?> scroll;

private CheckpointInfo lastCheckpointInfo;
private int processedEntityCount = 0;
Expand Down

0 comments on commit 694da2e

Please sign in to comment.