HSEARCH-4203 Add a deadline parameter to SelectionEntityLoader

integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/work/PojoIndexingPlanBaseIT.java

@@ -277,7 +277,7 @@ public void nullEntity() {
 			session.indexingPlan().delete( IndexedEntity.class, 3, null );
 			session.indexingPlan().delete( IndexedEntity.class, 4, null );
 
-			when( loaderMock.load( Arrays.asList( 1, 2 ) ) )
+			when( loaderMock.load( Arrays.asList( 1, 2 ), null ) )
 					.thenReturn( Arrays.asList( entity1, entity2 ) );
 
 			backendMock.expectWorks( IndexedEntity.INDEX )
@@ -393,12 +393,12 @@ public void nullEntity_state() {
 			loadedEntities.add( entity );
 			expectations.addOrUpdate( "10", b -> b.field( "value", "val10" ) );
 
-			when( loaderMock.load( idsToLoad ) ).thenReturn( loadedEntities );
+			when( loaderMock.load( idsToLoad, null ) ).thenReturn( loadedEntities );
 
 			expectations.createdThenExecuted();
 		}
 
-		verify( loaderMock ).load( any() );
+		verify( loaderMock ).load( any(), any() );
 	}
 
 	@Test

integrationtest/mapper/pojo-base/src/test/java/org/hibernate/search/integrationtest/mapper/pojo/work/operations/AbstractPojoIndexingOperationIT.java

@@ -143,7 +143,7 @@ protected final void expectLoading(Integer ... ids) {
 	}
 
 	protected final void expectLoading(List<Integer> ids, List<IndexedEntity> entities) {
-		when( loaderMock.load( ids ) ).thenReturn( entities );
+		when( loaderMock.load( ids, null ) ).thenReturn( entities );
 	}
 
 	protected final void expectOperation(CompletableFuture<?> futureFromBackend, int id, String providedRoutingKey, String value) {

mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/loading/SelectionEntityLoader.java

@@ -8,6 +8,8 @@
 
 import java.util.List;
 
+import org.hibernate.search.engine.common.timing.Deadline;
+
 /**
  * A loader for loading a small selection of entities, used in particular during search.
  * <p>
@@ -28,9 +30,12 @@ public interface SelectionEntityLoader<E> {
 	 * Loads the entities corresponding to the given identifiers, blocking the current thread while doing so.
 	 *
 	 * @param identifiers A list of identifiers for objects to load.
+	 * @param deadline The deadline for loading the entities, or {@code null} if there is no deadline.
+	 * Should be complied with on a best-effort basis: it's acceptable to ignore it,
+	 * but it means some timeouts in Hibernate Search will not work properly.
 	 * @return A list of entities, in the same order the identifiers were given.
 	 * {@code null} is inserted when an object is not found or has the wrong concrete type.
 	 */
-	List<E> load(List<?> identifiers);
+	List<E> load(List<?> identifiers, Deadline deadline);
 
 }

mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/loading/impl/JavaBeanSelectionEntityLoader.java

@@ -22,7 +22,7 @@ public JavaBeanSelectionEntityLoader(SelectionEntityLoader<E> delegate) {
 
 	@Override
 	public List<?> loadBlocking(List<?> identifiers, Deadline deadline) {
-		return delegate.load( identifiers );
+		return delegate.load( identifiers, deadline );
 	}
 
 }

mapper/pojo-base/src/main/java/org/hibernate/search/mapper/pojo/loading/spi/PojoSelectionEntityLoader.java

@@ -31,7 +31,9 @@ public interface PojoSelectionEntityLoader<E> {
 	 * Loads the entities corresponding to the given identifiers, blocking the current thread while doing so.
 	 *
 	 * @param identifiers A list of identifiers for objects to load.
-	 * @param deadline The deadline for loading the entities, or null if there is no deadline.
+	 * @param deadline The deadline for loading the entities, or {@code null} if there is no deadline.
+	 * Should be complied with on a best-effort basis: it's acceptable to ignore it,
+	 * but it means some timeouts in Hibernate Search will not work properly.
 	 * @return A list of entities, in the same order the references were given.
 	 * {@code null} is inserted when an object is not found or has an excluded types
 	 * (see {@link PojoSelectionLoadingStrategy#createLoader(Set)}).