Change when the default attach-javadocs execution runs

- to prevent it from running after moditect, that causes issues otherwise

build/parents/public/pom.xml

@@ -297,6 +297,17 @@
                                 </goals>
                                 <phase>process-resources</phase>
                             </execution>
+                            <execution>
+                                <!--
+                                    This is the default name of an execution that is added automatically if release profile is enabled.
+                                    We want to "override" it so that we can control when it is actually executed.
+                                 -->
+                                <id>attach-javadocs</id>
+                                <goals>
+                                    <goal>jar</goal>
+                                </goals>
+                                <phase>${javadoc.generate.jar.phase}</phase>
+                            </execution>
                         </executions>
                     </plugin>
                     <plugin>

pom.xml

@@ -352,6 +352,8 @@
         <!-- Overridden in profiles to disable the plugin (which doesn't have a 'skip' property...) -->
         <injection-plugin.phase>compile</injection-plugin.phase>
 
+        <javadoc.generate.jar.phase>none</javadoc.generate.jar.phase>
+
         <!-- Test settings -->
 
         <!-- Properties overridden in profiles to disable certain tests that only work with specific Java versions -->
@@ -1392,6 +1394,10 @@
                     <value>true</value>
                 </property>
             </activation>
+            <properties>
+                <!-- We want this execution to happen before moditect (which executes at package phase) -->
+                <javadoc.generate.jar.phase>prepare-package</javadoc.generate.jar.phase>
+            </properties>
             <build>
                 <plugins>
                     <plugin>