HSEARCH-3863 Add missing options to DistanceSortBuilder

hibernate · Feb 8, 2021 · 81e4484 · 81e4484
1 parent fe2fa37
commit 81e4484
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 3 deletions.
diff --git a/...org/hibernate/search/backend/elasticsearch/types/sort/impl/ElasticsearchDistanceSort.java b/...org/hibernate/search/backend/elasticsearch/types/sort/impl/ElasticsearchDistanceSort.java
@@ -67,6 +67,21 @@ public void center(GeoPoint center) {
 			this.center = center;
 		}
 
+		@Override
+		public void missingFirst() {
+			// TODO HSEARCH-3863 Support for ES
+		}
+
+		@Override
+		public void missingLast() {
+			// TODO HSEARCH-3863 Support for ES
+		}
+
+		@Override
+		public void missingAs(GeoPoint value) {
+			// TODO HSEARCH-3863 Support for ES
+		}
+
 		@Override
 		public void mode(SortMode mode) {
 			switch ( mode ) {

diff --git a/.../java/org/hibernate/search/backend/lucene/types/sort/impl/LuceneGeoPointDistanceSort.java b/.../java/org/hibernate/search/backend/lucene/types/sort/impl/LuceneGeoPointDistanceSort.java
@@ -49,6 +49,21 @@ public void center(GeoPoint center) {
 			this.center = center;
 		}
 
+		@Override
+		public void missingFirst() {
+			// TODO HSEARCH-3863 Support for Lucene
+		}
+
+		@Override
+		public void missingLast() {
+			// TODO HSEARCH-3863 Support for Lucene
+		}
+
+		@Override
+		public void missingAs(GeoPoint value) {
+			// TODO HSEARCH-3863 Support for Lucene
+		}
+
 		@Override
 		public void mode(SortMode mode) {
 			switch ( mode ) {

diff --git a/...in/java/org/hibernate/search/engine/search/sort/dsl/impl/DistanceSortOptionsStepImpl.java b/...in/java/org/hibernate/search/engine/search/sort/dsl/impl/DistanceSortOptionsStepImpl.java
@@ -71,19 +71,19 @@ public DistanceSortMissingValueBehaviorStep<DistanceSortOptionsStepImpl<PDF>> mi
 
 	@Override
 	public DistanceSortOptionsStepImpl<PDF> first() {
-		// TODO HSEARCH-3863 builder.missingFirst();
+		builder.missingFirst();
 		return this;
 	}
 
 	@Override
 	public DistanceSortOptionsStepImpl<PDF> last() {
-		// TODO HSEARCH-3863 builder.missingLast();
+		builder.missingLast();
 		return this;
 	}
 
 	@Override
 	public DistanceSortOptionsStepImpl<PDF> use(GeoPoint value) {
-		// TODO HSEARCH-3863 builder.missingAs( value );
+		builder.missingAs( value );
 		return this;
 	}
 

diff --git a/engine/src/main/java/org/hibernate/search/engine/search/sort/spi/DistanceSortBuilder.java b/engine/src/main/java/org/hibernate/search/engine/search/sort/spi/DistanceSortBuilder.java
@@ -17,6 +17,12 @@ public interface DistanceSortBuilder extends SearchSortBuilder {
 
 	void order(SortOrder order);
 
+	void missingFirst();
+
+	void missingLast();
+
+	void missingAs(GeoPoint value);
+
 	void mode(SortMode mode);
 
 	void filter(SearchPredicate filter);

diff --git a/...ate/search/util/impl/integrationtest/common/stub/backend/search/sort/StubSortBuilder.java b/...ate/search/util/impl/integrationtest/common/stub/backend/search/sort/StubSortBuilder.java
@@ -35,6 +35,11 @@ public void missingLast() {
 		// No-op
 	}
 
+	@Override
+	public void missingAs(GeoPoint value) {
+		// No-op
+	}
+
 	@Override
 	public void missingAs(Object value, ValueConvert convert) {
 		// No-op