HSEARCH-2916 Use a pessimistic lock in performance tests to avoid errors

hibernate · Oct 25, 2017 · a0a8f30 · a0a8f30
1 parent eee6dbd
commit a0a8f30
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...ce/orm/src/test/java/org/hibernate/search/test/performance/task/UpdateBookRatingTask.java b/...ce/orm/src/test/java/org/hibernate/search/test/performance/task/UpdateBookRatingTask.java
@@ -8,6 +8,7 @@
 
 import java.util.Random;
 
+import org.hibernate.LockMode;
 import org.hibernate.search.FullTextSession;
 import org.hibernate.search.test.performance.model.Book;
 import org.hibernate.search.test.performance.scenario.TestScenarioContext;
@@ -27,7 +28,8 @@ public UpdateBookRatingTask(TestScenarioContext ctx) {
 	@Override
 	protected void execute(FullTextSession fts) {
 		long bookId = ctx.getRandomBookId();
-		Book book = (Book) fts.get( Book.class, bookId );
+		// See HSEARCH-2916, we often had concurrent write errors here
+		Book book = (Book) fts.get( Book.class, bookId, LockMode.PESSIMISTIC_WRITE );
 		if ( book != null ) {
 			book.setRating( Math.abs( RANDOM_RATING.nextFloat() ) * MAX_RATING );
 		}

diff --git a/...orm/src/test/java/org/hibernate/search/test/performance/task/UpdateBookTotalSoldTask.java b/...orm/src/test/java/org/hibernate/search/test/performance/task/UpdateBookTotalSoldTask.java
@@ -6,6 +6,7 @@
  */
 package org.hibernate.search.test.performance.task;
 
+import org.hibernate.LockMode;
 import org.hibernate.search.FullTextSession;
 import org.hibernate.search.test.performance.model.Book;
 import org.hibernate.search.test.performance.scenario.TestScenarioContext;
@@ -22,7 +23,8 @@ public UpdateBookTotalSoldTask(TestScenarioContext ctx) {
 	@Override
 	protected void execute(FullTextSession fts) {
 		long bookId = ctx.getRandomBookId();
-		Book book = (Book) fts.get( Book.class, bookId );
+		// See HSEARCH-2916, we often had concurrent write errors here
+		Book book = (Book) fts.get( Book.class, bookId, LockMode.PESSIMISTIC_WRITE );
 		if ( book != null ) {
 			book.setTotalSold( book.getTotalSold() + 1 );
 		}