HSEARCH-4712 Add checkstyle rules to detect sync blocks to be replaced

hibernate · Jan 2, 2023 · c257518 · c257518
1 parent d8b368c
commit c257518
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/build/config/src/main/resources/checkstyle.xml b/build/config/src/main/resources/checkstyle.xml
@@ -94,6 +94,13 @@
             <property name="ignoreComments" value="true" />
         </module>
 
+        <!-- Do not use sync blocks on objects -->
+        <module name="RegexpSinglelineJava">
+            <property name="format" value="synchronized\s*\(\s*(?!this\b)\w+" />
+            <property name="message" value="Do not use `synchronized (someObject)` blocks. Instead use the `java.util.concurrent.locks.Lock`s. See HSEARCH-4712." />
+            <property name="ignoreComments" value="true" />
+        </module>
+
        <!-- Checks for imports -->
         <module name="AvoidStarImport" />
         <module name="RedundantImport" />