HSEARCH-3277 Remove the casts of IDs to Serializable where possible

hibernate · Sep 29, 2023 · ed7b733 · ed7b733
1 parent 6644fda
commit ed7b733
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/.../main/java/org/hibernate/search/mapper/orm/loading/impl/HibernateOrmMassEntityLoader.java b/.../main/java/org/hibernate/search/mapper/orm/loading/impl/HibernateOrmMassEntityLoader.java
@@ -6,7 +6,6 @@
  */
 package org.hibernate.search.mapper.orm.loading.impl;
 
-import java.io.Serializable;
 import java.util.List;
 
 import org.hibernate.FlushMode;
@@ -56,12 +55,11 @@ public void load(List<I> identifiers) throws InterruptedException {
 		transactionHelper.commit( session );
 	}
 
-	@SuppressWarnings("unchecked") // We can assume identifiers are serializable
 	private List<E> multiLoad(List<I> identifiers) {
 		return typeQueryLoader.createMultiIdentifierLoadAccess( session )
 				.with( options.cacheMode() )
 				.with( LockOptions.NONE )
-				.multiLoad( (List<Serializable>) identifiers );
+				.multiLoad( identifiers );
 	}
 
 	private List<E> queryByIds(List<I> identifiers) {

diff --git a/...a/org/hibernate/search/mapper/orm/loading/impl/HibernateOrmSelectionEntityByIdLoader.java b/...a/org/hibernate/search/mapper/orm/loading/impl/HibernateOrmSelectionEntityByIdLoader.java
@@ -6,7 +6,6 @@
  */
 package org.hibernate.search.mapper.orm.loading.impl;
 
-import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -87,7 +86,7 @@ protected List<E> doLoadEntities(List<?> allIds, Long timeout) {
 	private EntityKey[] toEntityKeys(List<?> ids) {
 		EntityKey[] entityKeys = new EntityKey[ids.size()];
 		for ( int i = 0; i < ids.size(); i++ ) {
-			Serializable id = (Serializable) ids.get( i );
+			Object id = ids.get( i );
 			EntityKey entityKey = sessionContext.session().generateEntityKey( id, entityPersister );
 			entityKeys[i] = ( entityKey );
 		}