HSEARCH-2237 ScopedAnalyzerReference shouldn't close the underlying a…

…nalyzer references
hibernate · Apr 22, 2016 · fadb49a · fadb49a
1 parent 95f7538
commit fadb49a
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/engine/src/main/java/org/hibernate/search/util/impl/ScopedAnalyzerReference.java b/engine/src/main/java/org/hibernate/search/util/impl/ScopedAnalyzerReference.java
@@ -91,12 +91,9 @@ private static ScopedAnalyzer createScopedAnalyzer(AnalyzerReference globalAnaly
 
 	@Override
 	public void close() {
-		if ( globalAnalyzer != null ) {
-			globalAnalyzer.close();
-		}
-		for ( AnalyzerReference entry : analyzers.values() ) {
-			entry.close();
-		}
+		// we don't close the underlying {@code AnalyzerReference}s as they might be used by other
+		// {@code ScopedAnalyzerReference}. It is especially true for the reference to the
+		// PassThroughAnalyzer which is shared statically.
 	}
 
 	/**