[30%] HSEARCH-1872 Create a proper API for sorting definitions #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelbernard
force-pushed
the
HSEARCH-1872
branch
from
e8bb047
to
a09315a
Compare
| * For distance sort without a query, use {@code byField("location").fromCoordinates(...)} | ||
| * or {@code byField("location").fromLatitude(...)} | ||
| */ | ||
| SortDistanceContext byDistanceFromSpatialQuery(Query query); |
There was a problem hiding this comment.
here I'm wondering if we could avoid references to the Lucene type 'query'.
Assuming in a next step we'll be able to control the Sort DSL directly on the Query Builder (the existing Query DSL), then such a thing would go away right?
There was a problem hiding this comment.
When we generalise the DSL, this would naturally be using the right generic type. I did not see a point in working on that now.
TODO Exceptional case and exception triggered And lots of TODO in the code
emmanuelbernard
force-pushed
the
HSEARCH-1872
branch
from
a09315a
to
179708d
Compare
|
Closing for now. Yoann is working on a new PR superseding this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows the interface needed to implement the DSL.
One can already play with it and compile the test code, not run it.