Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSEARCH-2095 LuceneQueryTranslator is forcing to export the whole imp… #1265

Merged
merged 1 commit into from Dec 19, 2016

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Dec 19, 2016

…l package to OSGi headers

Looks like procrastination paid off in this case: I could simply remove the OSGi export statement, this was probably resolved by some of our other changes.

@gunnarmorling am I missing something maybe?

https://hibernate.atlassian.net/browse/HSEARCH-2095

@yrodiere
Copy link
Member

@Sanne It's a bit odd, because LuceneQueryTranslator is definitely referenced from the Elasticsearch module: it is implemented in org.hibernate.search.elasticsearch.impl.ElasticsearchLuceneQueryTranslator.
Are we sure the Elasticsearch module is used in OSGi tests?

@Sanne
Copy link
Member Author

Sanne commented Dec 19, 2016

Are we sure the Elasticsearch module is used in OSGi tests?

I'm sure the Elasticsearch module is NOT tested within OSGi.

Previously though, the LuceneQueryTranslator class was needed to be exposed (initialized? I don't remember) even when not using Elasticsearch.

@yrodiere
Copy link
Member

@Sanne That's probably related to 4067e6c, where I moved code using this interface from the -orm module to the -engine module.

@Sanne
Copy link
Member Author

Sanne commented Dec 19, 2016

right, that's probably the reason this works now. Good job ;-)

@yrodiere yrodiere merged commit 4a499bd into hibernate:master Dec 19, 2016
@yrodiere
Copy link
Member

Merged, thanks!

@Sanne Sanne deleted the HSEARCH-2095 branch December 19, 2016 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants