HSEARCH-2501 Elasticsearch calendar resolution handling is not consistent with Lucene's #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t with the same value We used to keep the hour, minutes, etc. from the current date/time.
…stment with Elasticsearch on Lucene's behavior We truncate the date with the GMT timezone, even if the calendar has a different timezone.
…dex-time rounding The Elasticsearch integration fails testCalendarBridge when using non-GMT timezones. This is fixed with HSEARCH-2501.
|
Great, it even worked in the late evening 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-2501
Please note that with Lucene, we always truncate date/calendars with the GMT timezone, regardless of the timezone that has been set on the calendar.
If we are to solve this issue, I think we should solve it in a way that is consistent between ES and Lucene. For instance we could add a configuration option to set the timezone to use when truncating dates ('GMT', '+01:00', 'default' for the JVM's default, ...) and another for calendars (same options + another to instruct to use the calendar's timezone).
See also the thread I started on the hibernate-dev mailing list: http://lists.jboss.org/pipermail/hibernate-dev/2017-January/015712.html
For now, I made the Elasticsearch integration behave the same as Lucene.