HSEARCH-3287 Change the syntax of index configuration properties from h.s.myIndex.someProperty to h.s.indexes.myIndex.someProperty #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
added
the
Waiting for other pull request
![sonarcloud[bot]](https://avatars.githubusercontent.com/in/12526?s=60&v=4){kind=small}
|
|
||
| private final ConfigurationPropertySource propertySource; | ||
| private final UnusedPropertyTrackingConfigurationPropertySource unusedPropertyTrackingPropertySource; | ||
| private final HibernateOrmConfigurationPropertySource propertySource; |
There was a problem hiding this comment.
…backend => backends I.e. expect "indexes.nameOfIndex.someProperty" instead of "index.nameOfIndex.someProperty" in properties, and same for backend => backends.
gsmet
added
Ready for review
and removed
Waiting for other pull request
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net//browse/HSEARCH-3287
Based on #1784 , which should be merged first.
Most of the work was already done, I just had to change the prefix from "index" to "indexes" and from "backend" to "backends" to comply with our decision during the F2F meeting.