Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSEARCH-3395 Make the .reference() and .object() projections type-safe in the Projection DSL #1788

Merged
merged 2 commits into from Nov 5, 2018
Merged

HSEARCH-3395 Make the .reference() and .object() projections type-safe in the Projection DSL #1788

merged 2 commits into from Nov 5, 2018

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Nov 5, 2018

https://hibernate.atlassian.net//browse/HSEARCH-3395

Based on #1787 , which should be merged first.

@yrodiere yrodiere added the Waiting for other pull request Based on another PR that should be merged first label Nov 5, 2018
sonarcloud[bot]
sonarcloud bot reviewed Nov 5, 2018
View reviewed changes
Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 12

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  2. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  3. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  4. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  5. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  6. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  7. Code Smell Code Smell: Remove this unused private "getSingleAccess" method. (more)

See all issues in SonarCloud

@coveralls
Copy link

coveralls commented Nov 5, 2018 •
edited

Pull Request Test Coverage Report for Build 6

  • 119 of 156 (76.28%) changed or added relevant lines in 29 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 86.545%
Changes Missing Coverage Covered Lines Changed/Added Lines %
mapper/pojo/src/main/java/org/hibernate/search/mapper/pojo/mapping/impl/PojoSearchManagerDelegateImpl.java 15 16 93.75%
mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/search/impl/JavaBeanSearchTargetImpl.java 5 7 71.43%
mapper/orm/src/main/java/org/hibernate/search/mapper/orm/mapping/impl/HibernateOrmMappingImpl.java 1 3 33.33%
mapper/orm/src/main/java/org/hibernate/search/mapper/orm/search/impl/FullTextQueryResultDefinitionContextImpl.java 6 9 66.67%
backend/elasticsearch/src/main/java/org/hibernate/search/backend/elasticsearch/search/query/impl/ElasticsearchSearchTargetContext.java 1 6 16.67%
backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchTargetContext.java 1 6 16.67%
engine/src/main/java/org/hibernate/search/engine/common/impl/MappedIndexSearchTargetImpl.java 20 25 80.0%
mapper/javabean/src/main/java/org/hibernate/search/mapper/javabean/work/impl/JavaBeanWorkPlanImpl.java 8 22 36.36%
Totals Coverage Status
Change from base Build 52: -0.06%
Covered Lines: 11372
Relevant Lines: 13140
💛 - Coveralls

@yrodiere yrodiere force-pushed the HSEARCH-3395 branch 2 times, most recently from 157c959 to 06b6eea Compare November 5, 2018 14:18
sonarcloud[bot]
sonarcloud bot reviewed Nov 5, 2018
View reviewed changes
Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 11

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  2. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  3. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  4. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  5. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  6. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)

See all issues in SonarCloud

gsmet
gsmet reviewed Nov 5, 2018
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the CI feedback but as far AFAICS the changes look good.

sonarcloud[bot]
sonarcloud bot reviewed Nov 5, 2018
View reviewed changes
Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 11

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  2. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  3. Code Smell Code Smell: Remove this unused "singleAccess" private field. (more)
  4. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  5. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  6. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  7. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)

See all issues in SonarCloud

sonarcloud[bot]
sonarcloud bot reviewed Nov 5, 2018
View reviewed changes
Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 11

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  2. Code Smell Code Smell: Remove this unused "singleAccess" private field. (more)
  3. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  4. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  5. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  6. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  7. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)

See all issues in SonarCloud

@yrodiere yrodiere force-pushed the HSEARCH-3395 branch 2 times, most recently from 28fb6f0 to a7c9ee5 Compare November 5, 2018 15:04
sonarcloud[bot]
sonarcloud bot reviewed Nov 5, 2018
View reviewed changes
Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 10

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  2. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  3. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  4. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  5. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)
  6. Code Smell Code Smell: Complete the task associated to this TODO comment. (more)

See all issues in SonarCloud

...src/main/java/org/hibernate/search/mapper/javabean/session/JavaBeanSearchManagerBuilder.java Outdated
public interface JavaBeanSearchManagerBuilder extends PojoSearchManagerBuilder<PojoSearchManager> {
public interface JavaBeanSearchManagerBuilder {

// TODO other options (default query timeout, default query hints, ...)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Smell Code Smell: Complete the task associated to this TODO comment. (squid:S1135)

See it in SonarCloud

...ain/java/org/hibernate/search/mapper/orm/hibernate/FullTextQueryResultDefinitionContext.java Outdated
@@ -15,8 +15,8 @@
/**
* @author Yoann Rodiere
*/
public interface HibernateOrmSearchQueryResultDefinitionContext<O>
extends org.hibernate.search.mapper.orm.jpa.HibernateOrmSearchQueryResultDefinitionContext<O> {
public interface FullTextQueryResultDefinitionContext<O>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Smell Code Smell: Rename this interface. (squid:S2176)

See it in SonarCloud

.../src/main/java/org/hibernate/search/mapper/orm/jpa/FullTextQueryResultDefinitionContext.java Outdated
@@ -15,7 +15,7 @@
/**
* @author Yoann Rodiere
*/
public interface HibernateOrmSearchQueryResultDefinitionContext<O> {
public interface FullTextQueryResultDefinitionContext<O> {

// TODO add object loading options: ObjectLookupMethod, DatabaseRetrievalMethod, ...
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Smell Code Smell: Complete the task associated to this TODO comment. (squid:S1135)

See it in SonarCloud

.../main/java/org/hibernate/search/mapper/orm/session/spi/HibernateOrmSearchManagerBuilder.java Outdated
public interface SearchManagerBuilder<T extends SearchManager> {

// TODO other options (default query timeout, query hints, ...)
// TODO other options (default query timeout, default query hints, ...)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Smell Code Smell: Complete the task associated to this TODO comment. (squid:S1135)

See it in SonarCloud

@yrodiere
HSEARCH-3395 Require information about the type of references and loa…
ec40a65 
…ded objects when we create a SearchTarget

This is necessary if we want to create typed projections to references
and loaded objects (see following commits).
@yrodiere
HSEARCH-3395 Make the .reference() and .object() projections type-saf…
8ebe33d 
…e in the Projection DSL
@yrodiere yrodiere merged commit bdb4908 into hibernate:master Nov 5, 2018
@yrodiere
Copy link
Member Author

yrodiere commented Nov 5, 2018

Merged, thanks!

@yrodiere yrodiere deleted the HSEARCH-3395 branch November 16, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@sonarcloud sonarcloud[bot] sonarcloud left review comments

Assignees
No one assigned
Labels
Waiting for other pull request Based on another PR that should be merged first
Projects
None yet
Milestone
No milestone
3 participants
@yrodiere @coveralls @gsmet