Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSEARCH-2908 Incorrect mapping for 'java.lang.Short and java.lang.Byte' fields with Elasticsearch. #1891

Merged
merged 2 commits into from Feb 20, 2019
Merged

HSEARCH-2908 Incorrect mapping for 'java.lang.Short and java.lang.Byte' fields with Elasticsearch. #1891

merged 2 commits into from Feb 20, 2019

Conversation

fax4ever
Copy link
Contributor

https://hibernate.atlassian.net/browse/HSEARCH-2908

Based on top of #1889.
Thus we need to merge #1889 first.

@fax4ever fax4ever changed the title 2908 test es server effective field types HSEARCH-2908 Incorrect mapping for 'java.lang.Short and java.lang.Byte' fields with Elasticsearch. Feb 15, 2019
@coveralls
Copy link

coveralls commented Feb 17, 2019 •
edited

Pull Request Test Coverage Report for Build 3

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 88.465%
Totals Coverage Status
Change from base Build 154: 0.006%
Covered Lines: 15546
Relevant Lines: 17573
💛 - Coveralls

@yrodiere yrodiere added the Waiting for other pull request Based on another PR that should be merged first label Feb 18, 2019
@fax4ever fax4ever force-pushed the 2908-test-es-server-effective-field-types branch from e852822 to 1307461 Compare February 19, 2019 12:36
@fax4ever @yrodiere
HSEARCH-2908 Add test case to probe field types
635d0bb
@fax4ever @yrodiere
HSEARCH-2908 Rename Elasticsearch client Spy class
c16158c 
Using the Mocking nomenclature it is more a spy than a mock, since it calls a real Elasticsearch server.
@yrodiere yrodiere force-pushed the 2908-test-es-server-effective-field-types branch from 1307461 to c16158c Compare February 20, 2019 09:28
@yrodiere yrodiere added Ready for review and removed Waiting for other pull request Based on another PR that should be merged first labels Feb 20, 2019
@yrodiere yrodiere self-assigned this Feb 20, 2019
yrodiere
yrodiere approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Waiting for CI and Sonar report, and if everything is good I'll merge.

@yrodiere yrodiere merged commit 0f6eb70 into hibernate:master Feb 20, 2019
@yrodiere
Copy link
Member

Merged, thanks!

@fax4ever fax4ever deleted the 2908-test-es-server-effective-field-types branch February 20, 2019 10:44
@fax4ever
Copy link
Contributor Author

Thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

Assignees

@yrodiere yrodiere

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@fax4ever @coveralls @yrodiere