HSEARCH-3591 Expect a function as parameter for SearchQueryContext#sort #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3
💛 - Coveralls |
fax4ever
approved these changes
Jun 7, 2019
| @@ -19,11 +19,11 @@ | |||
| DefaultSearchQueryContext<H, C>, | |||
| H, | |||
| SearchPredicateFactoryContext, | |||
| SearchSortContainerContext, | |||
| SearchSortFactoryContext, | |||
For consistency with SearchQueryResultContext#predicate(Function<? super PDC,SearchPredicateTerminalContext>) and SearchQueryResultDefinitionContext#asProjection(Function<? super PJC,? extends SearchProjectionTerminalContext<P>>).
…eryResultContext.predicate(Function) For consistency with all the other, similar methods, such as NestedPredicateFieldContext#nest(Function<? super SearchPredicateFactoryContext,? extends SearchPredicateTerminalContext>).
…nal DSL state in SearchQueryContext#sort(Function) This is the first step to making the *structure* of sorts immutable in the Sort DSL.
Now that we don't rely on getResultingBuilders() to contribute sorts to the query, we can remove a lot of complexity, in particular the concept of SearchSortContributor which isn't necessary anymore. This also brings the sort DSL closer to the predicate and projection DSLs.
…ntext For consistency with the other DSLs, and because this name is now more fitting as the "factory context" is no longer mutable (you can't add sorts to it, you can just create other contexts that are based on it).
…Function) in tests Since we renamed the type from container to factory, that makes more sense. Plus, it's consistent with what we do for projections and predicates.
|
Thanks. I addressed your comment and rebased. Waiting for CI. |
…building composite sorts See in particular IndexSearchDocumentRepositoryImpl#searchAroundMe to get an idea of why we need this.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net//browse/HSEARCH-3591
Please review commit by commit, as commit messages explain why I do what I do.