HSEARCH-4736 Add offloading operation submitter #3400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
reviewed
Feb 2, 2023
...g/hibernate/search/backend/lucene/orchestration/impl/LuceneParallelWorkOrchestratorImpl.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/hibernate/search/engine/backend/work/execution/OperationSubmitter.java
Outdated
Show resolved
Hide resolved
...ain/java/org/hibernate/search/engine/backend/orchestration/spi/AbstractWorkOrchestrator.java
Outdated
Show resolved
Hide resolved
...a/org/hibernate/search/backend/lucene/orchestration/impl/LuceneSyncWorkOrchestratorImpl.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/hibernate/search/engine/backend/orchestration/spi/BatchingExecutorTest.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/hibernate/search/engine/backend/work/execution/OperationSubmitter.java
Show resolved
Hide resolved
...e/search/backend/elasticsearch/orchestration/impl/ElasticsearchBatchingWorkOrchestrator.java
Outdated
Show resolved
Hide resolved
marko-bekhta
force-pushed
the
feat/HSEARCH-4736-offloading-submitter
branch
3 times, most recently
from
f443347
to
1aa3dc5
Compare
yrodiere
reviewed
Feb 6, 2023
...ne/src/main/java/org/hibernate/search/engine/backend/orchestration/spi/BatchingExecutor.java
Show resolved
Hide resolved
engine/src/main/java/org/hibernate/search/engine/backend/work/execution/OperationSubmitter.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/hibernate/search/engine/backend/work/execution/OperationSubmitter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/hibernate/search/engine/common/execution/spi/SimpleScheduledExecutor.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/hibernate/search/engine/backend/work/execution/OperationSubmitter.java
Outdated
Show resolved
Hide resolved
marko-bekhta
force-pushed
the
feat/HSEARCH-4736-offloading-submitter
branch
from
1aa3dc5
to
0613405
Compare
yrodiere
approved these changes
Feb 7, 2023
...rc/test/java/org/hibernate/search/engine/backend/orchestration/spi/BatchingExecutorTest.java
Outdated
Show resolved
Hide resolved
.../java/org/hibernate/search/engine/backend/work/execution/OperationSubmitterExecutorTest.java
Show resolved
Hide resolved
...ne/src/main/java/org/hibernate/search/engine/backend/orchestration/spi/BatchingExecutor.java
Show resolved
Hide resolved
marko-bekhta
force-pushed
the
feat/HSEARCH-4736-offloading-submitter
branch
from
0613405
to
cf14b73
Compare
marko-bekhta
force-pushed
the
feat/HSEARCH-4736-offloading-submitter
branch
from
cf14b73
to
e2f3d49
Compare
|
SonarCloud Quality Gate failed. |
yrodiere
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-4736
I've tried to keep
OperationSubmitterclosed for the users, so they are forced to use whatever is provided with Search.Also, with this new submitter type, it is somewhat possible to offload work in
LuceneSyncWorkOrchestratorImplbut I wasn't sure if that's something worth supporting, so I left it more on the "idea level".I've kept the same "hacks" for the BatchExecutor test as in the blocking case as it seems we might stumble upon the same issue with offloading.