Hsearch 1442 - @IndexedEmbedded depth analysis is broken

[gsmet]

My coworker Yoann Rodière worked on a test case and a fix for HSEARCH-1442. This PR is for branch 4.4 as it's the current stable branch but it should be mergeable in all supported branches.

Feedback welcome.

[Hibernate-CI]

Merged build triggered.

[Hibernate-CI]

Merged build triggered.

[Hibernate-CI]

Merged build started.

[Hibernate-CI]

Merged build triggered.

[Hibernate-CI]

Merged build finished.

[Sanne]

the CI machine failed it because of some checkstyle rules but don't worry for those it's a trivial change I'll do when merging

[hferentschik]

To start with some administrative things, @fenrhil, have you already "signed" the JBoss CLA for Hibernate Search?

[yrodiere]

Hi Hardy,

I did sign the CLA on Dec 5, 2012. It was approved on Feb 6, 2013.

[hferentschik]

@fenrhil, thanks

[hferentschik]

I merged this fix to 4.4, 4.5 and master. Good catch @fenrhil :-)
For me this fix mainly reverts to the previous status quo. I agree with @gsmet that this solution does not seem 100% accurate, but by rewriting it, I might introduce another bug or different behaviour.

[Sanne]

thanks all!
expect to see releases from both 4.5 and 4.4 branches next week, or with some luck I'll start over the weekend.