Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OGM] 5.4.0.CR1 release #121

Merged
merged 1 commit into from
Oct 1, 2018
Merged

[OGM] 5.4.0.CR1 release #121

merged 1 commit into from
Oct 1, 2018

Conversation

fax4ever
Copy link
Contributor

@fax4ever fax4ever commented Oct 1, 2018

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My two cents. Looks good apart from that.


* We support Infinispan remote transaction over HotRod client
* Java types `java.time.LocalDate`, `java.time.LocalDateTime` and `java.time.LocalTime` are natively supported as a field types
* It is possible to configure MongoDB `ReadConcern` strategy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A link to our own documentation would help here, I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks @yrodiere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the new property has not been documented yet.

** Infinispan Remote: _org.hibernate.ogm:hibernate-ogm-featurepack-infinispan-remote:5.4.0.Beta2_
** Infinispan Embedded: _org.hibernate.ogm:hibernate-ogm-featurepack-infinispan-embedded:5.4.0.Beta2_
** MongoDB: _org.hibernate.ogm:hibernate-ogm-featurepack-mongodb:5.4.0.Beta2_
** Neo4j: _org.hibernate.ogm:hibernate-ogm-featurepack-neo4j:5.4.0.Beta2_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should update these version numbers.


* Hibernate ORM 5.3.4.Final
* Hibernate Search 5.10.4.Final
* Infinispan 5.3.3.Final
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a typo here. The Infinispan version seems wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There definitely is. Thanks

@fax4ever
Copy link
Contributor Author

fax4ever commented Oct 1, 2018

Thanks @yrodiere

@fax4ever
Copy link
Contributor Author

fax4ever commented Oct 1, 2018

I applied here also some @Sanne's tips. Thank you @Sanne

@fax4ever fax4ever merged commit 48e55a1 into hibernate:production Oct 1, 2018
@fax4ever fax4ever deleted the ogm branch October 1, 2018 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants