Retire OGM #163
Merged
Retire OGM #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
approved these changes
Mar 8, 2022
DavideD
reviewed
Mar 8, 2022
| %a.item{:href => "#{site.hibernate_org.base_url}ogm/"} OGM | ||
| %a.item{:href => "#{site.hibernate_org.base_url}tools/"} Tools | ||
| - if real_page.project == 'ogm' | ||
| %a.item{:href => "#{site.hibernate_org.base_url}ogm/"} OGM |
There was a problem hiding this comment.
I don't understand this change. Why can't you just remove it?
There was a problem hiding this comment.
🤷 That's what Guillaume did on hibernate.org, so I did the same here.
There was a problem hiding this comment.
Basically, we display the menu if people are in the OGM section already.
We do the same for the website.
There was a problem hiding this comment.
I kinda get it why we would do that in hibernate.org.
But why do we need it for in.relation.to? If you click on any button of the header it will go to hibernate.org
There was a problem hiding this comment.
By the way, I miss this in hibernate.org, but OGM should probably be after Others. This way we can think of it as a sub-voice of Others: Others > OGM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.