Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change class mappings from class to fqn-String #24

Closed
cerker opened this issue Mar 7, 2017 · 0 comments
Closed

Change class mappings from class to fqn-String #24

cerker opened this issue Mar 7, 2017 · 0 comments
Assignees
Milestone

Comments

@cerker
Copy link
Contributor

cerker commented Mar 7, 2017

Currently, the SessionManager holds a map with Class as key and BapiMapping as value. In applications where Bapi annotated classes reside in different modules which are loaded by different classloader this can lead to problems, e.g. multiple EAR deployments in an application server (like JBoss >= version 7 or Wildfly) with a central module doing the Hibersap configuration.

The map can be changed to have a String with the fully qualified class name. The disadvantage of this change is that we now rely on unique fully qualified class names for @bapi annotated classes. Having different classes with the same fqn should be considered a design flaw anyway, so this should not be a big problem.

@cerker cerker self-assigned this Mar 7, 2017
@cerker cerker added this to the 1.2.1 milestone Mar 7, 2017
@cerker cerker mentioned this issue Mar 8, 2017
@cerker cerker closed this as completed Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant