Add preHandler and postHandler for Scheduler #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hibiken
reviewed
May 25, 2022
scheduler.go
Outdated
| location *time.Location | ||
| done chan struct{} | ||
| wg sync.WaitGroup | ||
| preHandler func(task *Task, opts []Option) |
There was a problem hiding this comment.
(nit): rename this to preEnqueueFunc
scheduler.go
Outdated
| done chan struct{} | ||
| wg sync.WaitGroup | ||
| preHandler func(task *Task, opts []Option) | ||
| postHandler func(info *TaskInfo, err error) |
There was a problem hiding this comment.
(nit): rename this to postEnqueueFunc
Thanks for your remind. I've added it into CHANGELOG.md. |
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 68.28% 68.34% +0.06%
==========================================
Files 27 27
Lines 3821 3829 +8
==========================================
+ Hits 2609 2617 +8
Misses 928 928
Partials 284 284
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussion here