fix(274): listLeaseExpiredCmd ignore tasks those are no longer exist

[yeqown]

fix issue #274

[yeqown]

For more detail information, I've put them into issue already.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b422c2) 68.37% compared to head (fe18dde) 68.37%.
Report is 6 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   68.37%   68.37%           
=======================================
  Files          27       27           
  Lines        3836     3836           
=======================================
  Hits         2623     2623           
  Misses        929      929           
  Partials      284      284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yeqown]

What should I do with this codecov report? @kamikazechaser

[kamikazechaser]

codecov report

Personally, I think it is fine and would ignore it.

Though it would be good to know an easy way to reproduce this bug.

[yeqown]

Further more, I found the root cause is in the Lua script listLeaseExpiredCmd. while a task key is deleted manually, but it is still in a asynq:{qname}:lease key, listLeaseExpiredCmd return values would contains a nil item, and then be processed which produces the ZERO TaskMessage.

[yeqown]

@kamikazechaser Can you merge this?

[kamikazechaser]

I might need more info on how to reproduce the issue. From #274 it is not very clear on how this is encountered. But the change does look sensible in any case.

[darren128]

@kamikazechaser Can we get this merged?

[kamikazechaser]

LGTM

@hibiken We can merge this

[kamikazechaser]

Possibly related to #730.