Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect system locale, instead of defaulting to Korean #40

Closed
ghost opened this issue Jun 30, 2017 · 2 comments
Closed

Detect system locale, instead of defaulting to Korean #40

ghost opened this issue Jun 30, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Jun 30, 2017

If possible, switch default language to same as OS, browser, or some other anchor, instead of defaulting to Korean. It is a little clunky for English speakers, for example, to find the option in Korean to change to make it English so they can read the menus. It's not the end of the world if that cannot be done. Any way to poll the OS for it, or detect the language settings of the browser or browser toolkit that loads it?

Otherwise, this is a stellar piece of work, and using it is an absolute joy.

@hibiyasleep
Copy link
Owner

hibiyasleep commented Jul 1, 2017

image

This isn't possible as of now, since OverlayPlugin doesn't report system language correctly.

However this may fixed in next version of Plugin.

@hibiyasleep hibiyasleep changed the title If possible, switch language to same as OS, browser, or some other anchor, instead of defaulting to Korean Detect system locale, instead of defaulting to Korean Jul 1, 2017
@hibiyasleep
Copy link
Owner

Fixed with f20247d, kagerou will try to detect system locale at first launch (or after config reset).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant