Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown of ServerFuture #1976

Closed
nmittler opened this issue Jun 22, 2023 · 4 comments · Fixed by #1977
Closed

Graceful shutdown of ServerFuture #1976

nmittler opened this issue Jun 22, 2023 · 4 comments · Fixed by #1977

Comments

@nmittler
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When running a DNS server (via ServerFuture) as part of a larger application, it's desirable to include the shutdown of the DNS server as part of the shutdown workflow for the process.

Describe the solution you'd like
Ideally, the DNS server would support hooks to initiate a graceful shutdown, as well as notifying the application when the server shutdown has completed. During a graceful shutdown, the server would finish serving existing requests, but reject new requests.

Describe alternatives you've considered
NA

Additional context
This came up in an Istio PR, which adds a Trust-DNS-based proxy: istio/ztunnel#536 (comment)
@nmittler nmittler mentioned this issue Jun 22, 2023
Merged
@djc
Copy link
Collaborator

djc commented Jun 25, 2023

Sounds good to me to add something like this. Maybe look at how hyper models Server::with_graceful_shutdown()?

@nmittler
Copy link
Contributor Author

Sounds good, I'll take a look. I've already started some hacking using the linkerd drain crate, since that's what Istio is using currently. I'll compare and see what works best for ServerFuture.

nmittler added a commit to nmittler/trust-dns that referenced this issue Jun 25, 2023
@nmittler
Adding graceful shutdown to ServerFuture.
5e3e570 
This adds a dependency on [Linkerd drain](https://github.com/linkerd/drain-rs), which is used to allow the application to gracefully shutdown the DNS server.

Fixes hickory-dns#1976.
@nmittler nmittler mentioned this issue Jun 25, 2023
Merged
nmittler added a commit to nmittler/trust-dns that referenced this issue Jun 27, 2023
@nmittler
Adding graceful shutdown to server.
609c170 
Creating a `Server` object with a new interface to handle the various types of servers and their shutdown.

Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jun 27, 2023
@nmittler
Adding graceful shutdown to server.
cb0c0fc 
Creating a `Server` object with a new interface to handle the various types of servers and their shutdown.

Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jun 28, 2023
@nmittler
Adding graceful shutdown to server.
1f8866e 
Creating a `Server` object with a new interface to handle the various types of servers and their shutdown.

Fixes hickory-dns#1976.
@blaine
Copy link

blaine commented Jun 28, 2023

This is extremely apropos for us! Will be watching this, let us know if we can help. cc @zeeshanlakhani

nmittler added a commit to nmittler/trust-dns that referenced this issue Jun 29, 2023
@nmittler
Adding graceful shutdown to server.
80e6bcb 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jun 29, 2023
@nmittler
Adding graceful shutdown to server.
e8635d8 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jun 29, 2023
@nmittler
Adding graceful shutdown to server.
499e2c0 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jun 30, 2023
@nmittler
Adding graceful shutdown to server.
8a870ad 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jun 30, 2023
@nmittler
Adding graceful shutdown to server.
bd184c7 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jun 30, 2023
@nmittler
Adding graceful shutdown to server.
c621369 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jun 30, 2023
@nmittler
Adding graceful shutdown to server.
08293c5 
Fixes hickory-dns#1976.
@nmittler
Copy link
Contributor Author

nmittler commented Jul 1, 2023

@blaine @zeeshanlakhani FYI #1977 is out for review if you're interested

nmittler added a commit to nmittler/trust-dns that referenced this issue Jul 7, 2023
@nmittler
Adding graceful shutdown to server.
0066f41 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jul 9, 2023
@nmittler
Adding graceful shutdown to server.
59d5014 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jul 9, 2023
@nmittler
Adding graceful shutdown to server.
4e19dea 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jul 9, 2023
@nmittler
Adding graceful shutdown to server.
297fd40 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jul 9, 2023
@nmittler
Adding graceful shutdown to server.
27abb02 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jul 9, 2023
@nmittler
Adding graceful shutdown to server.
0d1b75f 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jul 10, 2023
@nmittler
Adding graceful shutdown to server.
a5bea20 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jul 10, 2023
@nmittler
Adding graceful shutdown to server.
0ed0aad 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jul 10, 2023
@nmittler
Adding graceful shutdown to server.
ce21981 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jul 10, 2023
@nmittler
Adding graceful shutdown to server.
e7a7604 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jul 29, 2023
@nmittler
Adding graceful shutdown to server.
ca1d6e1 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jul 30, 2023
@nmittler
Adding graceful shutdown to server.
44522b5 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jul 30, 2023
@nmittler
Adding graceful shutdown to server.
bf1f954 
Fixes hickory-dns#1976.
nmittler added a commit to nmittler/trust-dns that referenced this issue Jul 30, 2023
@nmittler
Adding graceful shutdown to server.
5ad6eee 
Fixes hickory-dns#1976.
bluejekyll pushed a commit that referenced this issue Aug 1, 2023
@nmittler @bluejekyll
Adding graceful shutdown to server.
578ce5a 
Fixes #1976.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding graceful shutdown to server nmittler/trust-dns
3 participants
@blaine @djc @nmittler