trigger more name_server errors in more cases #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluejekyll
force-pushed
the
fix-concurrent-resolution
branch
from
8d8d814
to
51f3158
Compare
Codecov Report
@@ Coverage Diff @@
## master #1086 +/- ##
==========================================
+ Coverage 84.94% 84.99% +0.05%
==========================================
Files 125 125
Lines 13407 13415 +8
==========================================
+ Hits 11388 11402 +14
+ Misses 2019 2013 -6 |
|
Unfortunately we currently can't test it since Vector is still on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on some work from #1085 this hopefully addresses the issues seen in #933
@ktff and @gabelerner would be interesting if you could test with this PR with your environments.