Catalog response code #1207
Merged
Catalog response code #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbb
force-pushed
the
catalog-response-code
branch
from
a60a7b1
to
78233ff
Compare
Codecov Report
@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
- Coverage 85.62% 85.61% -0.01%
==========================================
Files 125 125
Lines 13840 13923 +83
==========================================
+ Hits 11850 11920 +70
- Misses 1990 2003 +13 |
|
Did you look into combining this with a fix for proto's |
|
This was meant as a quick fix before I can take another look at #1203. The best way, for now, is probably to silently create the EDNS section whenever necessary. |
jonasbb
force-pushed
the
catalog-response-code
branch
from
78233ff
to
f3f3efe
Compare
jonasbb
added a commit
to jonasbb/trust-dns
that referenced
this pull request
Oct 26, 2020
Some ResponseCodes have high bits which require EDNS to encode them. This commit updates Message::set_response_code and MessageResponseBuiler::error_msg to silently create a EDNS section if required and sets the high bits there. This also adds a warning to Header::set_response_code that this function cannot set the high bits. Closes hickory-dns#1203 Closes hickory-dns#1207
|
What's the status on this change? |
|
@bluejekyll This 1 line change correctly sets the response code in the case of This code remains correct also with #1265 applied, but this PR could then be reverted if wanted. |
jonasbb
added a commit
to jonasbb/trust-dns
that referenced
this pull request
Mar 11, 2022
Some ResponseCodes have high bits which require EDNS to encode them. This commit updates Message::set_response_code and MessageResponseBuiler::error_msg to silently create a EDNS section if required and sets the high bits there. This also adds a warning to Header::set_response_code that this function cannot set the high bits. Closes hickory-dns#1203 Closes hickory-dns#1207
jonasbb
added a commit
to jonasbb/trust-dns
that referenced
this pull request
Mar 11, 2022
Some ResponseCodes have high bits which require EDNS to encode them. This commit updates Message::set_response_code and MessageResponseBuiler::error_msg to silently create a EDNS section if required and sets the high bits there. This also adds a warning to Header::set_response_code that this function cannot set the high bits. Closes hickory-dns#1203 Closes hickory-dns#1207
bluejekyll
approved these changes
Apr 10, 2022
|
I didn't see the updates on this. Sorry for the delayed merging and thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes how
Catalogsets theBADVERSresponse code.