-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make trust_dns_proto::rr::Record
serializable
#1536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, I think changing the url
serde option is the only thing to change.
I see the deprecation errors... we'll need to think about how to resolve that. |
Codecov Report
@@ Coverage Diff @@
## main #1536 +/- ##
=======================================
Coverage 83.37% 83.37%
=======================================
Files 171 171
Lines 16936 16936
=======================================
Hits 14120 14120
Misses 2816 2816 |
Inspired by rust-lang/rust#87454, it would be possible to do this in pub mod dnskey;
pub mod ds;
#[allow(deprecated)]
pub mod key;
pub mod nsec;
// ... Then we could remove the other What do you think about this? |
I just put up a PR for fixing the openssl dep on windows: #1543 |
ok, all tests are passing. Thanks for the PR! |
You're welcome, thanks for creating and maintaining this project :) |
When using the
serde-config
feature, I noticed that thetrust_dns_proto::rr::Record
is notDeserialize
andSerialize
. This can be achieved by adding a conditional derive to all its subtypes.There are some deprecation warnings for
crates/proto/src/rr/dnssec/rdata/key.rs
, but I'm not sure how to fix them.