Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass RequestInfo into Authority on search #1620

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Conversation

bluejekyll
Copy link
Member

Fixes: #1613

@moschroe, It took me a while to come back around to this.

This is a first pass at adding the request details to the Authority::search method, but should suffice for the original issue. I do want to extend this for DoH, DoT, and eventually DoQ to allow for client cert validation (of some form), though the TLS protocol may actually require a different method that's not authority based. We'll see.

@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #1620 (9e8ea5c) into main (d7aa80f) will decrease coverage by 0.01%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##             main    #1620      +/-   ##
==========================================
- Coverage   79.54%   79.53%   -0.01%     
==========================================
  Files         180      180              
  Lines       18095    18098       +3     
==========================================
+ Hits        14392    14393       +1     
- Misses       3703     3705       +2     

Copy link

@moschroe moschroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Provides all the necessary data in search().

@bluejekyll
Copy link
Member Author

@djc, I think this is a pretty simple change.

@moschroe, thanks for confirming. I think we'll want to expand RequestInfo at some point to also include an additional ProtocolInfo but I don't want to do that until I have a specific use case to test it out. My idea there is to use mTLS or similar to support dynamic update better.

Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question.

@bluejekyll bluejekyll merged commit 22ffc3f into main Feb 6, 2022
@bluejekyll bluejekyll deleted the request-info-authority branch February 6, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make low-level request details available in high-level APIs (like Authority)
3 participants