-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate edns methods, add extensions #1675
Conversation
Woop, forgot to re-run the tests lol. doh edit: |
b9de4f1
to
2c39e21
Compare
Codecov Report
@@ Coverage Diff @@
## main #1675 +/- ##
==========================================
- Coverage 79.92% 79.87% -0.05%
==========================================
Files 177 183 +6
Lines 18309 18597 +288
==========================================
+ Hits 14632 14853 +221
- Misses 3677 3744 +67 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. See this comment: #1675 (comment)
I think once that is changed in terms of usage, this is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. There's a minor unused error right now, this is ready once that's clean.
Let me know if you want an additional unit test or something to bump up the codecov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for fixing up this interface. And thanks for the PR.
Assuming we're still good to go ahead with this modification, for reference the workaround for not being able to remove EDNS, as best I can work out is:
Looking at all this, a
MessageBuilder
could probably help make constructing new Messages lot nicer, happy to sketch that out on an issue or something if you like. Let me know if you want to remove the MessageParts -> Message bit from this also... I included it here but if we pursue a builder maybe it's not as necessary.