Fixed some clippy warning

[darnuria]

Leaved the println! warnings.

[darnuria]

(have some more to fix i am on it)

[darnuria]

Look like clippy is... misleading on this one, suppose it was warn based on regex not AST.

 use of `unwrap_or` followed by a function call
   --> crates/proto/src/https/https_client_stream.rs:164:22
    |
164 |                     .unwrap_or(Ok(crate::https::MIME_APPLICATION_DNS))?;
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok(crate::https::MIME_APPLICATION_DNS))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
    = note: `-D clippy::or-fun-call` implied by `-D warnings`

[bluejekyll]

So for the failing option, would you mind adding this to the lib.rs in at least proto? it could be added to all the allows though: clippy::bool_to_int_with_if in https://github.com/bluejekyll/trust-dns/blob/d4d065e49b0e4b05b51a13324b9e4a1c20d0bb13/crates/proto/src/lib.rs#L23-L26

[djc]

This fails cleanliness CI, maybe because the lint isn't available on the clippy version that we run in CI?

[darnuria]

2022-10-18T23:58:41.8365550Z error: unknown lint: `clippy::bool_to_int_with_if`
2022-10-18T23:58:41.8366698Z   --> crates/proto/src/lib.rs:26:5
2022-10-18T23:58:41.8425708Z    |
2022-10-18T23:58:41.8426569Z 26 |     clippy::bool_to_int_with_if,
2022-10-18T23:58:41.8426831Z    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
2022-10-18T23:58:41.8427042Z    |
2022-10-18T23:58:41.8428048Z    = note: `-D unknown-lints` implied by `-D warnings`

Oh sorry didn't found time to check CI, will investigate today. @djc right I were in the future for this one will revert the commit and keep it for a later day.

My version of clippy:
clippy 0.1.66 (8b0c05d 2022-10-07)

EDIT: found time to do it.

• Rebased against origin/main
• splited the cast from the if commit
• Removed commit with allow, saved for a future day

[codecov]

Codecov Report

Merging #1801 (0094249) into main (29eeef4) will not change coverage.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##             main    #1801   +/-   ##
=======================================
  Coverage   80.40%   80.40%           
=======================================
  Files         177      177           
  Lines       18242    18242           
=======================================
  Hits        14668    14668           
  Misses       3574     3574           

Impacted Files	Coverage Δ
crates/proto/src/multicast/mdns_stream.rs	25.40% <50.00%> (ø)
crates/proto/src/rustls/tls_server.rs	88.88% <100.00%> (ø)
crates/proto/src/serialize/binary/bin_tests.rs	100.00% <100.00%> (ø)
crates/proto/src/xfer/dns_response.rs	96.14% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29eeef4...0094249. Read the comment docs.

[djc]

Thanks!