Simplify interface between BinEncoder and MaximalBuf #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluejekyll
reviewed
Oct 16, 2022
bluejekyll
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
enforced_write()method defined a pretty complex (and likely slow) interface contract. Add two separate methods toMaximalBufto replace all uses ofenforced_write(). This should fix the issue discovered in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=52334. At this point I'm not exactly sure in the root cause of the original issue (the fuzzed test case is still quite large), but I'm much more confident in the revised API.