Add --reverse, --file and --interval to util/resolve #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Previous code allowed for reverse lookups but required the user to pass `in-addr.arpa` hostnames. Passing `--reverse` makes the conversion automatically. * Minor changes to output to make the query type explicit.
The implementation reads one line of the input file every interval (default 1s) and asynchronously resolves it. Results are printed in the order their responses arrive. * Added --file and --interval to command-line parameters * Added clap group directives to mark invalid parameter combinations * Improved printing of queries and error messages
bluejekyll
approved these changes
Oct 25, 2022
|
I'm going to merge as is. I really like the reporting on errors being improved. nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
The ability to run reverse lookups. The previous code allowed for reverse lookups but required the user to pass
in-addr.arpahostnames. Passing--reversemakes the conversion automatically.The ability to resolve names given in a file (one name per line).
Happy to make adjustments or integrate any feedback to improve it further.