Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also declare MSRV in Cargo.toml #1820

Merged
merged 1 commit into from Nov 3, 2022
Merged

Also declare MSRV in Cargo.toml #1820

merged 1 commit into from Nov 3, 2022

Conversation

glts
Copy link
Contributor

@glts glts commented Nov 3, 2022

Follow-up to #1813: Also declare the MSRV in Cargo.toml, for the benefit of dependent apps and libraries.

See https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field.

Thank you.

Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I guess CI is failing because of the new clippy lints in 1.65, would you be willing to clean those up too?

@glts
Copy link
Contributor Author

glts commented Nov 3, 2022

I don’t really feel qualified to judge these lints (they seem somewhat subjective to me in this case).

If someone else wants to push commits here, feel free

Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think we can merge this. I'll take care of the cleanliness in a separate PR in a minute.

@bluejekyll bluejekyll merged commit ccd875b into hickory-dns:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants