Feature gate tokio features on mdns crate. #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Nov 15, 2022
|
Thanks! |
|
Does the failing test relate with this PR? |
Merged
4 tasks
|
Yeah, the failure seems unrelated. @bluejekyll any ideas? |
|
seems to have passed now :) |
|
Is there any chance we can get a patch-release with this in it? :) |
|
I can't do releases, only @bluejekyll can and he seems quite busy recently. Would need to start a 0.22.x maintenance branch because AFAICT main contains some incompatible changes. |
mergify bot
pushed a commit
to libp2p/rust-libp2p
that referenced
this pull request
Sep 4, 2023
On #3102 we left the `tokio-runtime` feature because of hickory-dns/hickory-dns#1830, meanwhile hickory-dns/hickory-dns#1831 was merged and `0.23.0` was released with it, so we no longer require the `tokio-runtime` feature. Pull-Request: #4418.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #1830