Move client code used by server code down into proto #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluejekyll
previously requested changes
Jan 10, 2023
There was a problem hiding this comment.
This looks good to me. I think it would be good to make the txt parsing portion of the library a default off feature. The resolver generally does not need any of that code, and I think it's enough that it probably makes a difference.
We could call it text-parsing or something like that?
djc
force-pushed
the
client-to-proto
branch
3 times, most recently
from
a73907f
to
8c7b85d
Compare
bluejekyll
reviewed
Jan 11, 2023
|
@djc take a look at my recent changes... I also fixed all the current cleanliness issues, separate commits. |
|
Sorry for losing sight of this, LGTM (I can't merge it since I'm the author). |
bluejekyll
approved these changes
Feb 6, 2023
|
I'm going to rebase and then merge... thanks @djc |
bluejekyll
force-pushed
the
client-to-proto
branch
from
b4932cb
to
a35f331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the low-level stuff in the client code was quite generic (and in fact used by the server).
As a future improvement, we might move all the networking stuff out of -proto into a trust-dns-net crate maybe? It would be nice if trust-dns-proto was sans-io.