Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: invalid benchmark #1900

Merged
merged 1 commit into from Mar 6, 2023
Merged

Fix: invalid benchmark #1900

merged 1 commit into from Mar 6, 2023

Conversation

XOR-op
Copy link
Contributor

@XOR-op XOR-op commented Mar 5, 2023

When users need to test the performance of resolver, they need to run

RUSTFLAGS="--cfg nightly" cargo +nightly bench --bench=comparison_benches

However, the commit 0643ee didn't clean the code. Users will fail the benchmark because the bench code invokes named, while it has been renamed to trust-dns. This commit fixes the bug.

@XOR-op
Copy link
Contributor Author

XOR-op commented Mar 5, 2023

CI encountered temporary HTTP 429 Too Many Requests, please rerun it. It passes tests on my fork.

@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Merging #1900 (05e8c2f) into main (778ce0c) will increase coverage by 0.02%.
The diff coverage is 88.05%.

❗ Current head 05e8c2f differs from pull request most recent head 4cdae10. Consider uploading reports for the commit 4cdae10 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1900      +/-   ##
==========================================
+ Coverage   80.26%   80.29%   +0.02%     
==========================================
  Files         192      192              
  Lines       19807    19830      +23     
==========================================
+ Hits        15899    15922      +23     
  Misses       3908     3908              
Impacted Files Coverage Δ
crates/async-std-resolver/src/lib.rs 100.00% <ø> (ø)
crates/resolver/src/lib.rs 100.00% <ø> (ø)
crates/resolver/src/quic.rs 0.00% <0.00%> (ø)
crates/server/src/store/forwarder/authority.rs 0.00% <0.00%> (ø)
crates/async-std-resolver/src/runtime.rs 76.47% <57.14%> (-14.44%) ⬇️
...rates/resolver/src/name_server/name_server_pool.rs 70.72% <76.47%> (ø)
...es/resolver/src/name_server/connection_provider.rs 85.82% <84.94%> (-0.15%) ⬇️
crates/resolver/src/https.rs 86.48% <88.88%> (+2.70%) ⬆️
crates/resolver/src/async_resolver.rs 88.18% <89.87%> (-0.42%) ⬇️
crates/async-std-resolver/src/tests.rs 88.88% <90.24%> (+0.31%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c77d19...4cdae10. Read the comment docs.

Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djc djc merged commit 5492bde into hickory-dns:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants