Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fuzz build #1911

Merged
merged 2 commits into from Apr 2, 2023
Merged

Fix fuzz build #1911

merged 2 commits into from Apr 2, 2023

Conversation

manunio
Copy link
Contributor

@manunio manunio commented Mar 24, 2023 •
edited

Fuzz build fails with following error, I'm not sure if this is right fix but adding fuzz to workspace.members fixes the error.

Step #3 - "compile-libfuzzer-address-x86_64": �[0m�[0m�[1m�[31merror�[0m�[1m:�[0m failed to parse manifest at `/src/trust-dns/fuzz/Cargo.toml`
Step #3 - "compile-libfuzzer-address-x86_64": 
Step #3 - "compile-libfuzzer-address-x86_64": Caused by:
Step #3 - "compile-libfuzzer-address-x86_64":   error inheriting `libfuzzer-sys` from workspace root manifest's `workspace.dependencies.libfuzzer-sys`
Step #3 - "compile-libfuzzer-address-x86_64": 
Step #3 - "compile-libfuzzer-address-x86_64": Caused by:
Step #3 - "compile-libfuzzer-address-x86_64":   failed to find a workspace root

This fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=57350

@manunio manunio marked this pull request as draft March 24, 2023 15:41
@manunio manunio marked this pull request as ready for review March 24, 2023 16:29
@manunio
Copy link
Contributor Author

manunio commented Mar 28, 2023

cc @bluejekyll @djc

bluejekyll
bluejekyll requested changes Mar 31, 2023
View reviewed changes
Cargo.toml Show resolved Hide resolved
@bluejekyll bluejekyll merged commit 1a3c346 into hickory-dns:main Apr 2, 2023
16 of 17 checks passed
@bluejekyll
Copy link
Member

Thanks for the PR!

@manunio manunio deleted the fix-oss-fuzz-build branch April 3, 2023 06:27
@manunio manunio mentioned this pull request Apr 5, 2023
Merged
DavidKorczynski pushed a commit to google/oss-fuzz that referenced this pull request Apr 5, 2023
@manunio
trust-dns: fix build (#10025)
6f00e32 
This PR along with hickory-dns/hickory-dns#1911
attempts to fix:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=57350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluejekyll bluejekyll bluejekyll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manunio @bluejekyll