Add the possibility to shuffle NameServers #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, this PR makes it possible to shuffle DNS NameServers to avoid overloads to the first configured ones. The default value for `shuffle_dns_servers` is set to true, it greatly improves performance in all kinds of tasks so IMO it makes sense to default to it. For comparison: A lookup for 11500 hosts, having 1000 resolvers, and using 100 threads takes ~10 minutes to complete, with this change it only takes 55 seconds. That means ~10x of performance increase. It's the continuation of hickory-dns#1632, I have tried implemeting `SmallRng`, however I haven't had success because it doesn't implement `Send` and therefore can't be send between threads safely. It can be improved in the future, but for now I think that it's a good start.
bluejekyll
requested changes
Apr 27, 2023
bluejekyll
approved these changes
May 7, 2023
|
@djc, I'm going to merge this unless you have concerns. |
djc
approved these changes
May 8, 2023
|
oops, I dropped the ball on this. @Edu4rdSHL , do you think you would mind rebasing this? |
Signed-off-by: Jens Reidel <adrian@travitia.xyz>
This commit updates the Rustls dependency to the recently released 0.21.0 tag, and to update tokio-rustls to 0.24.0 to use the same rustls release. It also updates webpki-roots to 0.23.0, and to use rustls' fork of webpki instead of the original. A couple of small upstream API changes are addressed to ensure the build and tests pass.
|
@bluejekyll done. |
|
Sorry for the delay. Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR makes it possible to shuffle DNS NameServers to avoid overloads to the first configured ones.
The default value for
shuffle_dns_serversis set to true, it greatly improves performance in all kinds of tasks so IMO it makes sense to default to it. For comparison:A lookup for 11500 hosts, having 1000 resolvers, and using 100 threads takes ~10 minutes to complete, with this change it only takes 55 seconds. That means ~10x of performance increase.
It's the continuation of #1632, I have tried implemeting
SmallRng, however I haven't had success because it doesn't implementSendand therefore can't be send between threads safely.It can be improved in the future, but for now I think that it's a good start.