Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto: avoid panicking in parse_time() #1964

Merged
merged 1 commit into from
Jun 9, 2023
Merged

proto: avoid panicking in parse_time() #1964

merged 1 commit into from
Jun 9, 2023

Conversation

djc
Copy link
Collaborator

@djc djc commented Jun 9, 2023

Substantially rewrite parse_time() to avoid duplication and make sure overflows result in an error.

Fixes #1963.

@djc djc requested a review from bluejekyll June 9, 2023 08:00
@djc djc mentioned this pull request Jun 9, 2023
Closed
bluejekyll
bluejekyll approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good cleanup. Thanks, @djc.

@bluejekyll bluejekyll mentioned this pull request Jun 9, 2023
Merged
@bluejekyll bluejekyll merged commit 01498f9 into main Jun 9, 2023
17 of 18 checks passed
@bluejekyll bluejekyll deleted the parse-time-error branch June 9, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluejekyll bluejekyll bluejekyll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zone parses time/TTL string (parse_time) panic when parsing a too long TTL string.
2 participants
@djc @bluejekyll